Update MACOSX_DEPLOYMENT_TARGET 10.13 -> 10.15 #6511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metascroy is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
hi @metascroy what is the test plan for these changes ? |
I added some context. How do you usually test these changes? I see this similar PR from 2 years ago, but don't see tests attached to it (#4069). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to bump the torchao pin in ExecuTorch, but CI jobs fail: pytorch/executorch#9947.
In particular this job fails: https://github.com/pytorch/executorch/actions/runs/14321828652/job/40140080161?pr=9947
The root cause is "/Users/runner/work/executorch/executorch/pytorch/executorch/third-party/ao/torchao/experimental/../../torchao/experimental/ops/memory.h:22:34: error: 'aligned_alloc' is only available on macOS 10.15 or newer [-Werror,-Wunguarded-availability-new]"
This is because the test infra defines the "export MACOSX_DEPLOYMENT_TARGET=10.13".